Skip to content

test: replace legacy tmpdir with tmp_path#1869

Merged
Lee-W merged 1 commit intomasterfrom
test-tmppath
Mar 14, 2026
Merged

test: replace legacy tmpdir with tmp_path#1869
Lee-W merged 1 commit intomasterfrom
test-tmppath

Conversation

@bearomorphism
Copy link
Collaborator

@bearomorphism bearomorphism commented Feb 14, 2026

Description

Checklist

Was generative AI tooling used to co-author this PR?

  • Yes (please specify the tool below)

Generated-by: [cursor] following the guidelines

Code Changes

  • Add test cases to all the changes you introduce
  • Run uv run poe all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Documentation Changes

  • Run uv run poe doc locally to ensure the documentation pages renders correctly
  • Check and fix any broken links (internal or external)

Expected Behavior

Steps to Test This Pull Request

Additional Context

@codecov
Copy link

codecov bot commented Feb 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.99%. Comparing base (dd972c9) to head (9bffb8c).
⚠️ Report is 25 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1869   +/-   ##
=======================================
  Coverage   97.98%   97.99%           
=======================================
  Files          60       60           
  Lines        2686     2689    +3     
=======================================
+ Hits         2632     2635    +3     
  Misses         54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bearomorphism bearomorphism marked this pull request as ready for review February 14, 2026 03:51
@bearomorphism bearomorphism force-pushed the test-tmppath branch 2 times, most recently from 5662cc7 to 72d1788 Compare March 14, 2026 06:27
@Lee-W Lee-W merged commit 339d80e into master Mar 14, 2026
20 checks passed
@Lee-W Lee-W deleted the test-tmppath branch March 14, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants